fix!: Remove access to the svelte/internal API which is deprecated #330
+78
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 18, 2024 01:18
…ed to be public.
Allows Svelte 5 compatibility.
BREAKING: remove support for the destroy() method on <Calendar />. Alternative: wrap the calendar in an {#if notDestroyed}<Calendar />{/if} block.
dummdidumm
reviewed
Sep 20, 2024
| } | ||
|
|
||
| for (var name of events) { | ||
| target.addEventListener(name, handler); |
There was a problem hiding this comment.
I recommend using Svelte's on method from svelte/events for this instead. Handles a few edge cases around event delegation which may or may not be relevant in this repo (I haven't checked)
|
@vkurko It would be realy helpfull if you could publish this to the npm registry |
Sorry, I wanted to fix some things before publishing the code, but I haven't had enough free time to do it yet. I think I'll definitely finish it this week. |
juhas96
added a commit
to juhas96/ng-vkurko-calendar
that referenced
this pull request
Oct 16, 2024
…cated (vkurko#330)" This reverts commit 9758b8f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES #235
Allows Svelte 5 compatibility.
BREAKING: removes support for the destroy() method on . Alternative: wrap the calendar in an {#if notDestroyed}{/if} block.